Fix for: zrok & ziti-router helm charts. Remove duplicated already defined labels

qdrddr · February 12, 2025, 3:51pm

Helm Chart Templates have duplicated already defined labels that prevents from charts to be deployed.

github.com/openziti/helm-charts

Fix for: zrok & ziti-router helm charts. Remove duplicated already defined labels

main ← qdrddr:main

opened 03:02PM - 12 Feb 25 UTC

qdrddr

+0 -6

- zrok - ziti-router Remove from spec.template.metadata.labels duplicated al…ready defined labels: - app.kubernetes.io/managed-by - app.kubernetes.io/instance - helm.sh/chart So it would not prevent deploying these helm charts, otherwise you can see error "unmarshal errors [...] mapping key [...] already defined" ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization helmCharts: - name: zrok repo: https://docs.openziti.io/helm-charts/ # version: 0.2.7 version: 0.2.7 releaseName: zrok namespace: openziti-system valuesFile: zrok-values.yaml includeCRDs: true - name: ziti-router repo: https://docs.openziti.io/helm-charts/ # version: 1.1.7 version: 1.1.7 releaseName: ziti-router namespace: openziti-system valuesFile: ziti-router-values.yaml includeCRDs: true ``` If not fixed, you'll get: ```shell kustomize build ./kustomizations --enable-helm > ./openziti.kustimized.yaml Error: map[string]interface {}(nil): yaml: unmarshal errors: line 27: mapping key "app.kubernetes.io/managed-by" already defined at line 22 line 29: mapping key "app.kubernetes.io/instance" already defined at line 23 line 25: mapping key "helm.sh/chart" already defined at line 24 ``` If I manually remove the duplicated lebels from spec.template.metadata.labels when I inflate the helm chart the resulting manifest will have spec.template.metadata.labels set inherited from the helm chart, confirming that setting them in the template is unneccessary.

qrkourier · February 12, 2025, 3:55pm

Good catch. Thanks for the patch!

qdrddr · February 12, 2025, 4:06pm

which versions of zrok & ziti-router helm charts will this be merged to?
the same or the next? And when it will be ready? Thanks @qrkourier

Current versions are:

zrok 0.2.7
ziti-router 1.1.7

qrkourier · February 12, 2025, 4:39pm

qrkourier · February 12, 2025, 5:11pm

Topic		Replies	Views
Correct Traefik Docker Labels to Secure Ziti for Zrok zrok	7	112	December 20, 2024
Helm ziti-edge-tunnel DNS not always resolving	4	206	December 15, 2023
Upgrading a ziti network (in K8s)	1	18	January 23, 2025
Controller setup on k8s, helm missing configMap Support	3	34	December 31, 2024
Deploying router on k8s via helm gives identity secret mount error	29	533	March 18, 2024

Fix for: zrok & ziti-router helm charts. Remove duplicated already defined labels

Related topics